Improve portfolio rendering, accessibility, and metadata consistency#10
Merged
Conversation
Resolves all 35 warnings from issue #3 across grouped sub-issues: - #5 design-no-redundant-size-axes: collapse w-N h-N to size-N (13) - #6 rendering-hydration-mismatch-time: suppressHydrationWarning on date elements (7) - #7 design: bg-black->bg-gray-950, font-bold->font-semibold, em-dash->comma (7) - #8 server async: Promise.all for independent awaits in blog/[slug]/page (3) - #9 nextjs/a11y/memo: metadata export, next/image, memo default const, Card keyboard a11y (5) Closes #5, closes #6, closes #7, closes #8, closes #9
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
React Doctor found no new issues. 🎉 Reviewed by React Doctor for commit |
pnpm-workspace.yaml (added in 1c09816) only contained allowBuilds and no 'packages:' field. Vercel's pnpm 9.x reads it as a workspace root and fails with 'packages field missing or empty'. The repo is not a monorepo and already declares build-allowed deps via package.json 'pnpm.onlyBuiltDependencies', so remove the file and gitignore it to prevent reintroduction by newer pnpm.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Resolves the React Review Audit in #3 (score 91/100, 35 warnings) by fixing every flagged diagnostic. The 35 warnings were grouped into five sub-issues, each fixed by a dedicated Claude Sonnet 4.6 worker thread and verified.
Closes #3
Sub-issues
design-no-redundant-size-axes(w-N h-N->size-N)rendering-hydration-mismatch-time(suppressHydrationWarningon date/year)no-pure-black-background(bg-black->bg-gray-950),design-no-bold-heading(font-bold->font-semibold),design-no-em-dash-in-jsx-text(em dash -> comma)server-sequential-independent-await(Promise.all),async-defer-awaitnextjs-missing-metadata,nextjs-no-img-element,rerender-memo-with-default-value,click-events-have-key-events,no-static-element-interactionsCloses #5, closes #6, closes #7, closes #8, closes #9
Changes
suppressHydrationWarningon the footer copyright year and on the blog date spans (blogs.tsx,blog/page.tsx,blog/[slug]/page.tsx).w-N h-Npairs to thesize-Nshorthand across cards, projects, blogs, and greeting.bg-blackwithbg-gray-950inpage.tsx,not-found.tsx,layout.tsx;font-bold->font-semiboldon card headings; em dash -> comma inabout.tsx.params/getPayload()awaits inPromise.allin bothgenerateMetadataand the page component ofblog/[slug]/page.tsx.export const metadatato the homepage, switched the avatar tonext/image(with agithub.comremote pattern innext.config.ts), extracted the memo default{}to a module-level constant indithering-shader.tsx, and gave the clickableCardrole="button",tabIndex, and an Enter/SpaceonKeyDownhandler..pnpm-storecache andpnpm-workspace.yaml.Vercel build fix
An earlier commit added a
pnpm-workspace.yamlcontaining onlyallowBuilds. Vercel's pnpm 9.x interprets anypnpm-workspace.yamlas a workspace root and failed withERR packages field missing or empty. This is a single-package repo that already declares build-allowed deps viapackage.json'spnpm.onlyBuiltDependencies, so the file was removed and gitignored, restoring the pnpm configuration to the known-working state ofmain.Testing
tsc --noEmit: passes (exit 0)next build: compiles successfully, all routes generated (exit 0)grepchecks: zero remaining flagged patterns (w-N h-N,bg-blackin JSX,font-boldin cards, raw<img>, em dash)pnpm lint: not runnable;eslintis not a dependency in this repo (pre-existing)Project board
GitHub project
celeroncoder-webupdated: sub-issues #5-#9 -> Done, #3 -> In review.